----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19420/#review37794 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java <https://reviews.apache.org/r/19420/#comment69521> Why don't we hard code the types for which clusterconfigmapping entries need to be created? If you run upgrade twice what will happen? - add missing config will skip the configs and this is expected - will this mapping query also skip adding clusterconfigmapping entries? - Sumit Mohanty On March 19, 2014, 8:14 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19420/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 8:14 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-5147 > https://issues.apache.org/jira/browse/AMBARI-5147 > > > Repository: ambari > > > Description > ------- > > As a part of ambari upgrade, customized log4j properties for HDP services > must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.). > Proposals: > 1. "ambari-server upgrade" command runs separate java software, which > connects to the Ambari DB and creates required *-log4j configs. Admin should > provide all log4j.properties files, for instance, copy them to predefined > directory on ambari-server node. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > b26091a > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java > 55697dc > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java > eb253a4 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java > b95a8bf > > ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml > 009acae > > Diff: https://reviews.apache.org/r/19420/diff/ > > > Testing > ------- > > > Thanks, > > Dmytro Sen > >
