> On March 19, 2014, 9:05 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java, > > line 593 > > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line593> > > > > Will this add all missing configs? Unless I misunderstood the patch. > > > > I think the scope of the JIRA is to add only the missing log4j configs. > > I think its risky to add all configs that are missing. User may not have > > deployed hbase/oozie and will get those configs as well.
These are the ones that may be missing. We also should add the "*log4j*" config only if the corresponding service is present. E.g. install hive-exec-log4j and hive-log4j only if HIVE service is present. ./1.3.2/services/HBASE/configuration/hbase-log4j.xml ./1.3.2/services/HDFS/configuration/hdfs-log4j.xml ./1.3.2/services/HIVE/configuration/hive-exec-log4j.xml ./1.3.2/services/HIVE/configuration/hive-log4j.xml ./1.3.2/services/MAPREDUCE/configuration/mapreduce-log4j.xml ./1.3.2/services/OOZIE/configuration/oozie-log4j.xml ./1.3.2/services/PIG/configuration/pig-log4j.xml ./1.3.2/services/ZOOKEEPER/configuration/zookeeper-log4j.xml ./2.0.6/services/HBASE/configuration/hbase-log4j.xml ./2.0.6/services/HDFS/configuration/hdfs-log4j.xml ./2.0.6/services/HIVE/configuration/hive-exec-log4j.xml ./2.0.6/services/HIVE/configuration/hive-log4j.xml ./2.0.6/services/OOZIE/configuration/oozie-log4j.xml ./2.0.6/services/PIG/configuration/pig-log4j.xml ./2.0.6/services/YARN/configuration/yarn-log4j.xml ./2.0.6/services/ZOOKEEPER/configuration/zookeeper-log4j.xml - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19420/#review37795 ----------------------------------------------------------- On March 19, 2014, 8:14 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19420/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 8:14 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-5147 > https://issues.apache.org/jira/browse/AMBARI-5147 > > > Repository: ambari > > > Description > ------- > > As a part of ambari upgrade, customized log4j properties for HDP services > must be imported into *-log4j configs(hdfs-log4j, hbase-log4j, etc.). > Proposals: > 1. "ambari-server upgrade" command runs separate java software, which > connects to the Ambari DB and creates required *-log4j configs. Admin should > provide all log4j.properties files, for instance, copy them to predefined > directory on ambari-server node. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > b26091a > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java > 55697dc > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java > eb253a4 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java > b95a8bf > > ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml > 009acae > > Diff: https://reviews.apache.org/r/19420/diff/ > > > Testing > ------- > > > Thanks, > > Dmytro Sen > >
