----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19523/#review38089 -----------------------------------------------------------
Overall changes look good. It would be great to add unit test coverage ambari-server/src/main/python/ambari-server.py <https://reviews.apache.org/r/19523/#comment70063> has it been tested under sles/rhel(centos) 5? ambari-server/src/main/python/ambari-server.py <https://reviews.apache.org/r/19523/#comment70066> do we ever use this value later? - Dmitro Lisnichenko On March 21, 2014, 11:30 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19523/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 11:30 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. > > > Bugs: AMBARI-5170 > https://issues.apache.org/jira/browse/AMBARI-5170 > > > Repository: ambari > > > Description > ------- > > Fix Ambari Setup on Ubuntu. > > Need to make sure ambari-server setup works fine on Ubuntu > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 5cec271 > > Diff: https://reviews.apache.org/r/19523/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 187 tests in 0.421s > > OK > ---------------------------------------------------------------------- > Total run:506 > Total errors:0 > Total failures:0 > > > Thanks, > > Vitalyi Brodetskyi > >
