----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19523/#review38318 -----------------------------------------------------------
Overall refactorings look good to me ambari-server/src/main/python/ambari-server.py <https://reviews.apache.org/r/19523/#comment70359> Let's move this check/command to utils module as well - Dmitro Lisnichenko On March 24, 2014, 5:05 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19523/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 5:05 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-5170 > https://issues.apache.org/jira/browse/AMBARI-5170 > > > Repository: ambari > > > Description > ------- > > Fix Ambari Setup on Ubuntu. > > Need to make sure ambari-server setup works fine on Ubuntu > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 5cec271 > ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION > ambari-server/src/test/python/TestAmbariServer.py 54e4077 > ambari-server/src/test/python/TestUtils.py PRE-CREATION > > Diff: https://reviews.apache.org/r/19523/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 187 tests in 0.421s > > OK > ---------------------------------------------------------------------- > Total run:506 > Total errors:0 > Total failures:0 > > > Thanks, > > Vitalyi Brodetskyi > >
