-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20717/
-----------------------------------------------------------
Review request for Ambari and Sumit Mohanty.
Bugs: AMBARI-5574
https://issues.apache.org/jira/browse/AMBARI-5574
Repository: ambari
Description
-------
We have had some reports of Agent-Server communication going down because of
JSON parsing error. This is usually a malformed JSON that either the agent
sends or receives. We need some WARN level log to spit out the JSON when such
error is encountered.
The possibility is that the Agent logs the last JSON sent to the server when it
encounters a communication error with the server. And, similarly, it can log
the JSON received if response processing encounters an error. At Controller.py,
the heartbeat loop we can log response or data or both based on when the
failure occurs.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py f1099ae
ambari-agent/src/main/python/ambari_agent/security.py 3052245
ambari-agent/src/test/python/ambari_agent/TestController.py 000cb3f
ambari-agent/src/test/python/ambari_agent/TestSecurity.py db4b25e
Diff: https://reviews.apache.org/r/20717/diff/
Testing
-------
All tests passed
Thanks,
Dmytro Sen
