----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20717/#review41487 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On April 25, 2014, 5:24 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20717/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 5:24 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-5574 > https://issues.apache.org/jira/browse/AMBARI-5574 > > > Repository: ambari > > > Description > ------- > > We have had some reports of Agent-Server communication going down because of > JSON parsing error. This is usually a malformed JSON that either the agent > sends or receives. We need some WARN level log to spit out the JSON when such > error is encountered. > The possibility is that the Agent logs the last JSON sent to the server when > it encounters a communication error with the server. And, similarly, it can > log the JSON received if response processing encounters an error. At > Controller.py, the heartbeat loop we can log response or data or both based > on when the failure occurs. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Controller.py f1099ae > ambari-agent/src/main/python/ambari_agent/security.py 3052245 > ambari-agent/src/test/python/ambari_agent/TestController.py 000cb3f > ambari-agent/src/test/python/ambari_agent/TestSecurity.py db4b25e > > Diff: https://reviews.apache.org/r/20717/diff/ > > > Testing > ------- > > All tests passed > > Ran 301 tests in 28.056s > > OK > [INFO] > [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: src/examples/* > [INFO] Exclude: src/test/python/dummy*.txt > [INFO] Exclude: src/test/python/ambari_agent/dummy_files/* > [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt > [INFO] Exclude: src/main/python/ambari_agent/imports.txt > [INFO] Exclude: src/main/puppet/modules/stdlib/** > [INFO] Exclude: **/*.erb > [INFO] Exclude: **/*.json > [INFO] 551 resources included (use -debug for more details) > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 407 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > > > Thanks, > > Dmytro Sen > >
