-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21559/
-----------------------------------------------------------

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-5793
    https://issues.apache.org/jira/browse/AMBARI-5793


Repository: ambari


Description
-------

There are two issues here.
Due to an earlier jira, nagios_web_password had a hard coded default since it 
wasn't yet specified in the stack.
If multiple passwords are required in different configurations for the same 
host group, not all missing passwords are reported to the user.

For the first issue the solution is to simply not provide a default value for 
the nagios_web_password.
For the second issue, needed to fix code that added missing properties to map 
so that they aren't overridden.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 8b6c39a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
 cd764ec 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
 f8bb351 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
 cff9aad 

Diff: https://reviews.apache.org/r/21559/diff/


Testing
-------

Unit Tests:
- added unit tests for this scenario
Ran all unit tests but ran into one previously known issue.
Waiting for this issue to be resolved.

Functional Tests:
Performed manual functional testing of this scenario.


Thanks,

John Speidel

Reply via email to