----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21566/#review43346 -----------------------------------------------------------
ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py <https://reviews.apache.org/r/21566/#comment77445> re.findall(":([\d]{1,5})(?=/|$)", address) port number might consist of 5 digits maximum - Dmytro Sen On May 16, 2014, 7:29 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21566/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 7:29 p.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-5797 > https://issues.apache.org/jira/browse/AMBARI-5797 > > > Repository: ambari > > > Description > ------- > > Pre-1.6.1 had a a function get_port_from_url that was working. In 1.6.1 this > is broken: > > 1.6.1: uses urlparse function which does not work with a definition like so: > 0.0.0.0:12345 > > 1.6.0: (correctly) uses address.split(':')[-1] > > > Diffs > ----- > > > ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py > ce9185b > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/21566/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
