----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21566/#review43370 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On May 19, 2014, 4:15 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21566/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 4:15 p.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-5797 > https://issues.apache.org/jira/browse/AMBARI-5797 > > > Repository: ambari > > > Description > ------- > > Pre-1.6.1 had a a function get_port_from_url that was working. In 1.6.1 this > is broken: > > 1.6.1: uses urlparse function which does not work with a definition like so: > 0.0.0.0:12345 > > 1.6.0: (correctly) uses address.split(':')[-1] > > > Diffs > ----- > > > ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py > ce9185b > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json > ce92689 > ambari-server/src/test/python/stacks/1.3.2/configs/default.json 8eabd30 > > ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json > d9b928d > ambari-server/src/test/python/stacks/1.3.2/configs/secured.json fe3d6f6 > ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json > 105d0b7 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json > 4817a58 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 3f5220e > > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json > b30714c > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json > 931f202 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json 0ea0db3 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json dce20fa > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 12de853 > ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json > ecf5031 > ambari-server/src/test/python/stacks/2.1/configs/default.json fdac02a > ambari-server/src/test/python/stacks/2.1/configs/secured.json 8e76ef5 > > Diff: https://reviews.apache.org/r/21566/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
