-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23654/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Bugs: AMBARI-6528
    https://issues.apache.org/jira/browse/AMBARI-6528


Repository: ambari


Description
-------

Added endpoint and ResourceProvider for alert definitions.  This is really just 
to get the endpoint going, and all the other CRUD operations will be in another 
JIRA.  Also updated some DAO, Entity and SQL fixes from Jonathan.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertDefResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 43578c6 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 2a87c4f 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 9bbebf5 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 29ca8a0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
 15c382b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d71cb8c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 f68f21c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 b70f335 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
 6f084df 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
 c5a9186 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
 aa99a08 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
 98af71d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
 6df6be2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java
 c1e346a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
 bc3958e 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
 595a3b8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
44bc369 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java
 PRE-CREATION 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a42153 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
deb70ab 
  ambari-server/src/main/resources/key_properties.json 68aa632 
  ambari-server/src/main/resources/properties.json a6cdac4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
 a4ee74b 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 71bc1f8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
 b34a7dd 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/23654/diff/


Testing
-------

Unit test and manual testing against the endpoint.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:53.464s
[INFO] Finished at: Thu Jul 17 15:34:30 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole

Reply via email to