> On Feb. 5, 2014, 7:18 p.m., Sumit Mohanty wrote: > > Got it. Thanks for the explanation. > > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > > * import org.apache.ambari.server.*; -- can you expand it back > > > > > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > > * import static org.easymock.EasyMock.* -- same as above > > > > Can you add a unit test for "getTransitiveServices"? > > > > There is one scenario about which I am a little concerned. Let me know if > > its correct. > > > > Now, if we start any service, it will look for the dependencies and then > > start them. For example, OOZIE start will start MR, HDFS etc. Is this > > correct? If yes should we allow that? > > Sumit Mohanty wrote: > If my understanding is correct, then lets implement a flag > (startDependentServices) and when that is true we traverse the dependency and > start all services. We can have the FE use the flag for the HDFS + ZK > situation. Considering the dependencies defined in the RCO file is quite > complex, starting all dependent services may run into issue. So lets not do > that by default. > > Dmytro Sen wrote: > The scenario, you're concerned about, is correct. > I'll add the flag and a unit test
Added unit test and flag param/start_dependencies. If it set to true , then all transitive services will be started automatically. If the flag is absent or = false, then only service(-s) in request will be started. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17668/#review33705 ----------------------------------------------------------- On July 23, 2014, 4:23 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17668/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 4:23 p.m.) > > > Review request for Ambari, Nate Cole and Sumit Mohanty. > > > Bugs: AMBARI-4513 > https://issues.apache.org/jira/browse/AMBARI-4513 > > > Repository: ambari > > > Description > ------- > > The expected behavior is Ambari need to start ZooKeeper as an HDFS service > dependency if the users did not start ZooKeeper services prior to starting > HDFS. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > d1e85df > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > dd99d87 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 21dcdc8 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > ea0d7ee > ambari-server/src/main/resources/properties.json 4d5407c > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > e51cea3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > b46736d > > ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java > db3fb91 > > Diff: https://reviews.apache.org/r/17668/diff/ > > > Testing > ------- > > OK > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [0.066s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.025s] > [INFO] Ambari Web ........................................ SUCCESS [7.912s] > [INFO] Ambari Views ...................................... SUCCESS [1.422s] > [INFO] Ambari Server ..................................... SUCCESS > [10:35.494s] > [INFO] Ambari Agent ...................................... SUCCESS [15.707s] > [INFO] Ambari Client ..................................... SUCCESS [0.210s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > > > Thanks, > > Dmytro Sen > >
