----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17668/#review48527 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java <https://reviews.apache.org/r/17668/#comment85185> Expand imports before pushing, even if there's a +1 (the code is ok). - Nate Cole On July 23, 2014, 12:23 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17668/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 12:23 p.m.) > > > Review request for Ambari, Nate Cole and Sumit Mohanty. > > > Bugs: AMBARI-4513 > https://issues.apache.org/jira/browse/AMBARI-4513 > > > Repository: ambari > > > Description > ------- > > The expected behavior is Ambari need to start ZooKeeper as an HDFS service > dependency if the users did not start ZooKeeper services prior to starting > HDFS. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > d1e85df > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > dd99d87 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 21dcdc8 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > ea0d7ee > ambari-server/src/main/resources/properties.json 4d5407c > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > e51cea3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > b46736d > > ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java > db3fb91 > > Diff: https://reviews.apache.org/r/17668/diff/ > > > Testing > ------- > > OK > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [0.066s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.025s] > [INFO] Ambari Web ........................................ SUCCESS [7.912s] > [INFO] Ambari Views ...................................... SUCCESS [1.422s] > [INFO] Ambari Server ..................................... SUCCESS > [10:35.494s] > [INFO] Ambari Agent ...................................... SUCCESS [15.707s] > [INFO] Ambari Client ..................................... SUCCESS [0.210s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > > > Thanks, > > Dmytro Sen > >
