-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24978/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-6959
https://issues.apache.org/jira/browse/AMBARI-6959
Repository: ambari
Description
-------
Right now service metainfo definition provides
configuration-dependencies tag that is exposed in the API as configTypes
field.
API should expose two different fields:
**1\. configTypesDependencies:**
Name of all the configuration types on which the service is dependent. UI will
use this for **service restart required functionality**. NOTE: This can be
more than the configuration carried by the service. Example Hive service does
not expose tez-site configs but requires restart when tez-configs change.
**2\. configTypes:**
Name of all the configuration types that the service carries in it's
configuration folder. UI will use this to **display configType section and
configurations on the service config page**.
As of now UI Uses the same field to provide both functionality by hard-coding
the references to the services in the web-code which can lead to potential
bugs when service metainfo.xml is changed with to address just one
functionality
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
c62e48d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/core-site.xml
60f01ad
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/core-site.xml
60f01ad
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
548ab88
Diff: https://reviews.apache.org/r/24978/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk