-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24978/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 1:52 p.m.)
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-6959
https://issues.apache.org/jira/browse/AMBARI-6959
Repository: ambari
Description
-------
Right now service metainfo definition provides
configuration-dependencies tag that is exposed in the API as configTypes
field.
This behaviour is wrong, what should be exposed is name of all the
configuration types that the service carries in it's
configuration folder. UI will use this to **display configType section and
configurations on the service config page**.
As of now UI Uses the field to provide functionality by hard-coding
the references to the services in the web-code (see below) which can lead to
potential
bugs when service metainfo.xml is changed with to address just one
functionality.
if (this.get('serviceName') !== 'HDFS') {
configTypes = configTypes.without('core-site');
}
//Falcon has dependency on oozie-site but oozie-site advanced/custom section
should not be shown on Falcon page
if (this.get('serviceName') !== 'OOZIE') {
configTypes = configTypes.without('oozie-site');
}
//Hive has dependency on tez-site but tez-site advanced/custom section should
not be shown on Hive page
if (this.get('serviceName') !== 'TEZ') {
configTypes = configTypes.without('tez-site');
}
//oozie has dependency on yarn-site but yarn-site advanced/custom section
should not be shown on Oozie page
if (this.get('serviceName') !== 'YARN') {
configTypes = configTypes.without('yarn-site');
}
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
c62e48d
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/core-site.xml
60f01ad
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/core-site.xml
60f01ad
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/core-site.xml
60f01ad
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/core-site.xml
60f01ad
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
548ab88
Diff: https://reviews.apache.org/r/24978/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
