----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25731/#review54196 -----------------------------------------------------------
Looks like its GCE and not GCC: https://cloud.google.com/products/compute-engine/. Can we change that in the patch? Other than that it looks good. - Mahadev Konar On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25731/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 12:11 p.m.) > > > Review request for Ambari, Mahadev Konar and Yusaku Sako. > > > Bugs: AMBARI-7357 > https://issues.apache.org/jira/browse/AMBARI-7357 > > > Repository: ambari > > > Description > ------- > > AWS provides a metadata service which the agent can use to resolve and set > the host's public hostname. Similar to that GCC provides almost the same > metadata service, the only difference is that at GCC there is no public > hostname only public IP. We could use this IP as the public hostname as the > hosts are not reachable any other way outside the VPC. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145 > > Diff: https://reviews.apache.org/r/25731/diff/ > > > Testing > ------- > > Tested on AWS and GCC > > > Thanks, > > Krisztian Horvath > >
