----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25731/#review54205 -----------------------------------------------------------
This seems like a good fix to make "quick links" work out of the box when the cluster is deployed on GCE. However, as mentioned in the corresponding JIRA, this patch has a side effect of showing IP addresses, rather than hostnames, in the Hosts page and Host Detail page in Ambari Web UI. This is a result of these pages using public hostnames rather than internal hostnames as they should. We ideally change the Hosts and Host Detail pages to show internal hostname instead, but this is sort of a big UI change for those who are used to the current behavior and would be a surprise. This level of change in the UI behavior is justified for the 2.0 release, so I say hold off on committing this until the 1.7.0 branch is cut (and we'll commit the accompanying UI changes together). Thoughts? - Yusaku Sako On Sept. 17, 2014, 12:11 p.m., Krisztian Horvath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25731/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 12:11 p.m.) > > > Review request for Ambari, Mahadev Konar and Yusaku Sako. > > > Bugs: AMBARI-7357 > https://issues.apache.org/jira/browse/AMBARI-7357 > > > Repository: ambari > > > Description > ------- > > AWS provides a metadata service which the agent can use to resolve and set > the host's public hostname. Similar to that GCC provides almost the same > metadata service, the only difference is that at GCC there is no public > hostname only public IP. We could use this IP as the public hostname as the > hosts are not reachable any other way outside the VPC. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/hostname.py 9fbe145 > > Diff: https://reviews.apache.org/r/25731/diff/ > > > Testing > ------- > > Tested on AWS and GCC > > > Thanks, > > Krisztian Horvath > >
