> On Sept. 26, 2014, 4:36 p.m., Sumit Mohanty wrote: > > ambari-web/app/controllers/main/host/details.js, line 1126 > > <https://reviews.apache.org/r/26000/diff/2/?file=705318#file705318line1126> > > > > This should be reviewed by Xi or someone from the front end team. My > > concern is that this > > "START" command bypasses all statemachine in the back end. I am not > > sure if that is now OK. The other implementation of recommission use > > RESTART.
Sumit, I wrote that correct state machine behaviour I'll implement in other task. I have tested this solution and have not got exception about state machine transition. This solution is ompact only RS decommosssion/start/stop. Other slave components like DN and NM work as before. I have added doRecommissionAndStartRegionServer because DN and NM throw exception if mark_draining_only attribute is not empty (defined in java), so I split doRecommissionAndStart to actual doRecommissionAndStart and specific doRecommissionAndStartRegionServer functions to prevent exceptions. I think we should ignore wrong transitions in state machine if component already in desired state. Why? because we have two different sources of changing states: 1. Custom and normal commands 2. Status commands So, if we use custom or normal command to STOP component state of component will be tried change twice (by command SUCCSESS and result of status command). Could you approve this solution? - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26000/#review54689 ----------------------------------------------------------- On Sept. 25, 2014, 1:37 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26000/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 1:37 p.m.) > > > Review request for Ambari, Dmytro Sen and Sumit Mohanty. > > > Bugs: AMBARI-7478 > https://issues.apache.org/jira/browse/AMBARI-7478 > > > Repository: ambari > > > Description > ------- > > STR: > Install cluster with default settings and all components at all nodes > Go on the host detail page > Turn on Maintenance mode for Regoin Server > Put Region Server in Decommission state > Check state of all Region Servers > Actual result: > Region Servers are stopped, except Decommissioned Region Server. > Expected result > Region Servers are started, except Decommissioned Region Server. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java > 8a9799d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_decommission.py > 4f7ed9e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py > ed086dc > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > a2261fb > ambari-web/app/controllers/main/host/details.js 39d9086 > > Diff: https://reviews.apache.org/r/26000/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [4.523s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.387s] > [INFO] Ambari Web ........................................ SUCCESS [32.579s] > [INFO] Ambari Views ...................................... SUCCESS [15.778s] > [INFO] Ambari Admin View ................................. SUCCESS [23.420s] > [INFO] Ambari Server ..................................... SUCCESS > [22:08.456s] > [INFO] Ambari Agent ...................................... SUCCESS [9.785s] > [INFO] Ambari Client ..................................... SUCCESS [0.040s] > [INFO] Ambari Python Client .............................. SUCCESS [0.272s] > [INFO] Ambari Groovy Client .............................. SUCCESS [10.898s] > [INFO] Ambari Shell ...................................... SUCCESS [0.042s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.049s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [7.661s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:54.793s > [INFO] Finished at: Wed Sep 24 22:44:29 FET 2014 > [INFO] Final Memory: 38M/395M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
