> On Oct. 1, 2014, 4:12 p.m., Sumit Mohanty wrote: > > ambari-web/app/controllers/main/host/details.js, line 1123 > > <https://reviews.apache.org/r/26000/diff/3/?file=709339#file709339line1123> > > > > There is not much difference between these two methods, do we need a > > separate one just for the extra flag - "mark_drain_only" > > > > Also, why is the API call to start is different between the two? > > > > 1c1 > > < doRecommissionAndStartRegionServer: function (hostNames, > > serviceName, componentName, slaveType) { > > --- > > > doRecommissionAndStart: function (hostNames, serviceName, > > componentName, slaveType) { > > 21c21 > > < "exclusive":"true", > > --- > > > "exclusive": true, > > 24d23 > > < "mark_draining_only": true, > > 42c41 > > < "uri": App.get('apiPrefix') + "/clusters/" + > > App.get('clusterName') +"/hosts/" + hostNames + "/host_components/" + > > slaveType, > > --- > > > "uri": App.get('apiPrefix') + "/clusters/" + > > App.get('clusterName') + "/host_components/" + slaveType, > > Dmytro Shkvyra wrote: > Sumit, "mark_drain_only" caused exceptions for NM and DN because > AmbariCustomCommandExecutionHelper.java. I'll remove it because we should not > use custom commands for STOP/START. Thanks.
Sumit, I have just tested this solution and it will not work fine. Because mark_drain_only should be defined exactly (true or false) because python parsing. So, last version of patch correct. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26000/#review55082 ----------------------------------------------------------- On Sept. 30, 2014, 3:52 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26000/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 3:52 p.m.) > > > Review request for Ambari, Dmytro Sen and Sumit Mohanty. > > > Bugs: AMBARI-7478 > https://issues.apache.org/jira/browse/AMBARI-7478 > > > Repository: ambari > > > Description > ------- > > STR: > Install cluster with default settings and all components at all nodes > Go on the host detail page > Turn on Maintenance mode for Regoin Server > Put Region Server in Decommission state > Check state of all Region Servers > Actual result: > Region Servers are stopped, except Decommissioned Region Server. > Expected result > Region Servers are started, except Decommissioned Region Server. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_decommission.py > 4f7ed9e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py > ed086dc > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > a2261fb > ambari-web/app/controllers/main/host/details.js 3fad22e > > Diff: https://reviews.apache.org/r/26000/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [4.523s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.387s] > [INFO] Ambari Web ........................................ SUCCESS [32.579s] > [INFO] Ambari Views ...................................... SUCCESS [15.778s] > [INFO] Ambari Admin View ................................. SUCCESS [23.420s] > [INFO] Ambari Server ..................................... SUCCESS > [22:08.456s] > [INFO] Ambari Agent ...................................... SUCCESS [9.785s] > [INFO] Ambari Client ..................................... SUCCESS [0.040s] > [INFO] Ambari Python Client .............................. SUCCESS [0.272s] > [INFO] Ambari Groovy Client .............................. SUCCESS [10.898s] > [INFO] Ambari Shell ...................................... SUCCESS [0.042s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.049s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [7.661s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:54.793s > [INFO] Finished at: Wed Sep 24 22:44:29 FET 2014 > [INFO] Final Memory: 38M/395M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
