[
https://issues.apache.org/jira/browse/AMBARI-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173271#comment-14173271
]
Yusaku Sako commented on AMBARI-7601:
-------------------------------------
[~vitthal_gogate]
> I think the real requirement would be to have Admin/User of Ambari be able to
> select which metrics/graphs to be displayed and change them as required
> through Ambari UI. Ambari should display the default set of metrics graphs. I
> assume this Jira does not address this requirement, right?
That is the end goal but out of scope for this JIRA.
> So I assume this is just a refactor of code on the web-ui side and ultimately
> these default set of metrics graphs be part of stack definition and Web UI
> would pick up the list from there, right? If so having a single file
> (service_graph_config.js) at this point across stacks is okay. Although I
> assume in future it would be part of the stack definition and not kept in the
> ".js" file on web-ui side.. ?
The patch posted is just a refactor of code on the UI side. When I filed this
JIRA originally, the intent was to move the metric graph definition in the
stack and have the UI load this information from there, as you can see from the
title and description.
Somehow this JIRA converted into a UI refactor, which is a step in the right
direction, but significant descoped :)
> Is there a separate Jira to move the default metrics list to stack
> definition? Current Jira description is bit misleading as it expects graphs
> to display be part of stack definition. May be we can correct the description
> of this jira and file new Jira to move the default metrics list to stack
> definition?
Clearly, this was (is?) the JIRA to move the default metrics list to stack
definition. Since the patch is already attached to JIRA to do UI refactor, we
create another JIRA and change the title/description accordingly.
> Service pluggability: metrics graphs to show in Ambari Web's service pages
> should be declared in the stack definition
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: AMBARI-7601
> URL: https://issues.apache.org/jira/browse/AMBARI-7601
> Project: Ambari
> Issue Type: Bug
> Components: ambari-web, stacks
> Affects Versions: 1.7.0
> Reporter: Yusaku Sako
> Assignee: Saman Alvi
> Attachments: AMBARI-7601.patch
>
>
> Currently, which metrics graphs to display in Ambari Web's service pages is
> hardcoded in ambari-web code.
> We should make it such that 1) the graphs to display are declared in the
> stack definition for each service and 2) ambari-web code needs to load this
> information and display appropriate graphs under the service page.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
