> On Oct. 27, 2014, 3:15 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py, > > lines 43-44 > > <https://reviews.apache.org/r/27230/diff/1/?file=734122#file734122line43> > > > > Just curious, why a tuple and not a list? tuples are like struct's, > > heterogenous and lists are typically homogenous
I chose a tuple since they are immutable - I agree that lists are for homogenous collections. I'd like to keep it a tuple for now since I really don't know why I might have to return from this function int he future. > On Oct. 27, 2014, 3:15 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py, > > line 77 > > <https://reviews.apache.org/r/27230/diff/1/?file=734123#file734123line77> > > > > May want to check into alternatives here, we've been burned with this > > when socket.getfqdn() doesn't return what the process is bound to. Fixed. I didn't realize that this could be something other than the host name that is accessible from this host. Thanks for pointing out that the host name is part of the base alert and can be passed into the scripts. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27230/#review58657 ----------------------------------------------------------- On Oct. 27, 2014, 12:21 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27230/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 12:21 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-7986 > https://issues.apache.org/jira/browse/AMBARI-7986 > > > Repository: ambari > > > Description > ------- > > Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT > alerts. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > c506c32 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json > c97775d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/27230/diff/ > > > Testing > ------- > > Each script was tested against an installed cluster for each possible path: > 1) Invalid URLs > 2) URLs that return unexpected data > 3) URLs that return correct data > > > Thanks, > > Jonathan Hurley > >
