----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27230/#review58684 -----------------------------------------------------------
ambari-server/src/main/resources/host_scripts/alert_disk_space.py <https://reviews.apache.org/r/27230/#comment99773> host_name is not actually used in this function. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py <https://reviews.apache.org/r/27230/#comment99776> In all of these tuples, (a, b) == ((a, b)) ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py <https://reviews.apache.org/r/27230/#comment99777> Can just use "if security_enabled:" - Alejandro Fernandez On Oct. 27, 2014, 9:11 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27230/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 9:11 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-7986 > https://issues.apache.org/jira/browse/AMBARI-7986 > > > Repository: ambari > > > Description > ------- > > Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT > alerts. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0 > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766 > ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > c506c32 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json > c97775d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json > d4af868 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/27230/diff/ > > > Testing > ------- > > Each script was tested against an installed cluster for each possible path: > 1) Invalid URLs > 2) URLs that return unexpected data > 3) URLs that return correct data > > > Thanks, > > Jonathan Hurley > >
