----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27635/#review60039 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java <https://reviews.apache.org/r/27635/#comment101379> Please add javadoc wherever possible. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java <https://reviews.apache.org/r/27635/#comment101377> Why return null? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java <https://reviews.apache.org/r/27635/#comment101376> Should notifyCreate be called only if at least one property was found (which also implies all required properties exist)? ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java <https://reviews.apache.org/r/27635/#comment101387> Should repoversion_id be a Long? ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql <https://reviews.apache.org/r/27635/#comment101388> We should use VARCHAR2 for Oracle - Alejandro Fernandez On Nov. 5, 2014, 7:15 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27635/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 7:15 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8164 > https://issues.apache.org/jira/browse/AMBARI-8164 > > > Repository: ambari > > > Description > ------- > > Create API and BE support for creating/retrieving repository versions > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > c611191 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 4f69dbb > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 52b0ba6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > a5f5b05 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > cb6c271 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > fe4729e > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 14c385d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > ebc8f5c > ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb > ambari-server/src/main/resources/key_properties.json c1a6636 > ambari-server/src/main/resources/properties.json 36cff96 > > Diff: https://reviews.apache.org/r/27635/diff/ > > > Testing > ------- > > Results : > > Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14 > > ... > > Total run: 684 > Total errors:0 > Total failures:0 > > > Thanks, > > Yurii Shylov > >
