> On Nov. 5, 2014, 7:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, > > lines 114-116 > > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line114> > > > > Not knowing how people will name repos, is it possible the same name > > can be used between stacks? What if they name it simply "2.3"? > > Dmitro Lisnichenko wrote: > FYI: some repos like HDP-UTILS seem to be shared between upgrade versions. > > Yurii Shylov wrote: > We should encourage people to give meaningful names for repositories. Its > name is the first thing they'll look at in UI, and if we allow duplicates for > names, it will rize the probability to make a mistake. > In this context display_name is the name of the whole repositories set, > so it doesn't matter that HDP-UTILS will be the same.
Makes sense, thanks - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27635/#review60003 ----------------------------------------------------------- On Nov. 6, 2014, 12:59 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27635/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 12:59 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8164 > https://issues.apache.org/jira/browse/AMBARI-8164 > > > Repository: ambari > > > Description > ------- > > Create API and BE support for creating/retrieving repository versions > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > c611191 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 52b0ba6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > a5f5b05 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > cb6c271 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > fe4729e > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 14c385d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > ebc8f5c > ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb > > Diff: https://reviews.apache.org/r/27635/diff/ > > > Testing > ------- > > Results : > > Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14 > > ... > > Total run: 684 > Total errors:0 > Total failures:0 > > > Thanks, > > Yurii Shylov > >
