----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27871/#review60862 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java <https://reviews.apache.org/r/27871/#comment102266> John mentioned in the Jira that we should consider making the kerberos descriptor it's own resource. Not sure if that makes sense but it probably needs some discussion. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java <https://reviews.apache.org/r/27871/#comment102270> This is a good idea but might not be enough. In the case where someone has a partial response request for ?fields= StackServices, it should return all of the properties under that category. Also, we support requesting a single element of a map property so in theory someone could make a request like ?fields= StackServices/kerberos_descriptor/someProperty. I think in both of those cases the check would fail when we really do want to get the descriptor. We need a method that has the logic of setResourceProperty that simply checks and returns a boolean. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java <https://reviews.apache.org/r/27871/#comment102272> Is there a quick check that could be done to see if the descriptor has changed since the last request? That way the property could be cached and only re-retrieved if needed. - Tom Beerbower On Nov. 11, 2014, 4:29 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27871/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 4:29 p.m.) > > > Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and > Tom Beerbower. > > > Bugs: AMBARI-8247 > https://issues.apache.org/jira/browse/AMBARI-8247 > > > Repository: ambari > > > Description > ------- > > Provide a way for a caller via the REST API to get information about a > service's Kerberos descriptor. This information should probably be attached > to a service resource response. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 2794c18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 1296ba1 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > 843df0b > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > 279361b > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 9277ec6 > ambari-server/src/main/resources/properties.json 36cff96 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 4d08d6f > > ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java > 225213f > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/27871/diff/ > > > Testing > ------- > > > Thanks, > > Robert Levas > >
