> On Nov. 11, 2014, 5:11 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java, > > lines 149-159 > > <https://reviews.apache.org/r/27871/diff/1/?file=757999#file757999line149> > > > > Is there a quick check that could be done to see if the descriptor has > > changed since the last request? That way the property could be cached and > > only re-retrieved if needed.
`kerberos.json` is a static document stored in the stack, so it only really needs to be read in once. However it could change if the stack is updated, but Ambari is restarted when that happens anyways. As for caching, there will be on descriptor file per service, so it would be rather memory intensive. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27871/#review60862 ----------------------------------------------------------- On Nov. 11, 2014, 11:29 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27871/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 11:29 a.m.) > > > Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and > Tom Beerbower. > > > Bugs: AMBARI-8247 > https://issues.apache.org/jira/browse/AMBARI-8247 > > > Repository: ambari > > > Description > ------- > > Provide a way for a caller via the REST API to get information about a > service's Kerberos descriptor. This information should probably be attached > to a service resource response. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 2794c18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 1296ba1 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > 843df0b > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > 279361b > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 9277ec6 > ambari-server/src/main/resources/properties.json 36cff96 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 4d08d6f > > ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java > 225213f > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/27871/diff/ > > > Testing > ------- > > > Thanks, > > Robert Levas > >
