----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28311/#review62542 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/28311/#comment104600> The second argument is not a cluster name, it's a log directory. It's apparently unused (and I don't even know why it's there in the first place, no one knows :) ). I'm working on having it removed. - Nate Cole On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28311/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 9:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii > Shylov. > > > Bugs: AMBARI-8406 > https://issues.apache.org/jira/browse/AMBARI-8406 > > > Repository: ambari > > > Description > ------- > > Replace stub restart with an actual restart command. Needed a slight > refactor to move required common code out of AMCI > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 4103621 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 9d3a1f8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9138ec2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > e068508 > > Diff: https://reviews.apache.org/r/28311/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:02.228s > [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014 > [INFO] Final Memory: 30M/666M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
