> On Nov. 21, 2014, 7:47 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 574 > > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574> > > > > is it intended to have such value for a cluster name? > > Dmitro Lisnichenko wrote: > Also, I have almost the same code for creating a stage for distribute > repos/install packages and sending a custom action to all hosts. How about > moving this createRestartStage() method somewhere to helper class so I can > generify and reuse it? > > Nate Cole wrote: > Let's discuss. Not sure why distribute/install requires a restart. > Firing a single custom action that is not a restart is pretty straightforward. > > Dmitro Lisnichenko wrote: > Since different hosts with different service components installed have > different package sets, we have to send individual install_packages custom > action to every host. In order to let multiple custom actions to execute in > parallel, we either have to bind them to different requests or put them all > into a single stage.
It's only semantics about how the work gets done. For now put them all in a single request with a single stage. Even on a cluster with 1000 hosts, we still need 1000 units of work done. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28311/#review62541 ----------------------------------------------------------- On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28311/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 9:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii > Shylov. > > > Bugs: AMBARI-8406 > https://issues.apache.org/jira/browse/AMBARI-8406 > > > Repository: ambari > > > Description > ------- > > Replace stub restart with an actual restart command. Needed a slight > refactor to move required common code out of AMCI > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 4103621 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 9d3a1f8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 9138ec2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > e068508 > > Diff: https://reviews.apache.org/r/28311/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:02.228s > [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014 > [INFO] Final Memory: 30M/666M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
