----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28736/#review63956 -----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js <https://reviews.apache.org/r/28736/#comment106309> Operating systems and repo names should not be hardcoded. These should be derived from the stack definition (especially the repo names). We should either fix it in this JIRA, or open another JIRA to address these and add TODO comments in the code. ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js <https://reviews.apache.org/r/28736/#comment106310> These should be retrieved from the stack definition. We need to retrieve stacks that have an upgrade pack associated. Either fix in this JIRA or create another JIRA/add TODO comment. ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js <https://reviews.apache.org/r/28736/#comment106311> HDP should not be hardcoded. Fix or TODO. - Yusaku Sako On Dec. 5, 2014, 3:07 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28736/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 3:07 a.m.) > > > Review request for Ambari, Andrii Tkach and Yusaku Sako. > > > Bugs: AMBARI-8554 > https://issues.apache.org/jira/browse/AMBARI-8554 > > > Repository: ambari > > > Description > ------- > > Ambari View > Versions > Versions table + Registration E2E integration > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > ae984b8 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 698bc6c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > c474918 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js > ae499cc > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html > 11e954f > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 97e67c9 > > Diff: https://reviews.apache.org/r/28736/diff/ > > > Testing > ------- > > Manually tested on live cluster. No unit test applicable. > > > Thanks, > > Richard Zang > >
