----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28736/#review63982 -----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js <https://reviews.apache.org/r/28736/#comment106358> Better to use local variable and then set final array to $scope.stacks, because changes to $scope.stacks affect DOM. ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js <https://reviews.apache.org/r/28736/#comment106356> Repository version should take value of Version Name input, not a combination of stack and version. ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js <https://reviews.apache.org/r/28736/#comment106355> I guess display name should be arbitrary label entered by user ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js <https://reviews.apache.org/r/28736/#comment106357> The /api/v1/stacks/HDP/versions/2.2/operating_systems?fields=repositories/* already contains properties of repositories such as "repo_id" and "repo_name", only "base_url" could be modified - Andrii Tkach On Дек. 5, 2014, 3:07 д.п., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28736/ > ----------------------------------------------------------- > > (Updated Дек. 5, 2014, 3:07 д.п.) > > > Review request for Ambari, Andrii Tkach and Yusaku Sako. > > > Bugs: AMBARI-8554 > https://issues.apache.org/jira/browse/AMBARI-8554 > > > Repository: ambari > > > Description > ------- > > Ambari View > Versions > Versions table + Registration E2E integration > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > ae984b8 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 698bc6c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > c474918 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/StackVersions.js > ae499cc > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html > 11e954f > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 97e67c9 > > Diff: https://reviews.apache.org/r/28736/diff/ > > > Testing > ------- > > Manually tested on live cluster. No unit test applicable. > > > Thanks, > > Richard Zang > >
