-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29167/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 2:12 p.m.)


Review request for Ambari, John Speidel, Nate Cole, Robert Nettleton, and Tom 
Beerbower.


Bugs: AMBARI-8756
    https://issues.apache.org/jira/browse/AMBARI-8756


Repository: ambari


Description
-------

When setting the Cluster session attributes, they should be set before 
performing the update operations since the attributes may be needed during the 
process.

Soltions sets session attributes before updating the cluster by using the 
`cluster ID` from the `request` to get relevant `cluster` rather than rely on 
the `cluster name`; since the name could be changing per the request data.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 435c828 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 4db01b9 

Diff: https://reviews.apache.org/r/29167/diff/


Testing (updated)
-------

Updated org.apache.ambari.server.controller.AmbariManagementControllerImplTest 
to mock changed workflow
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.945 sec

Full test suite failed to complete due to external issues with Jenkins - 

```
Build timed out (after 60 minutes). Marking the build as aborted.
Build was aborted
Archiving artifacts
Sending artifact delta relative to Ambari-trunk-test-patch #971
ERROR: Failed to archive 
{patch-work/trunkJavacWarnings.txt=patch-work/trunkJavacWarnings.txt, 
patch-work/filteredPatchJavacWarnings.txt=patch-work/filteredPatchJavacWarnings.txt,
 
patch-work/filteredTrunkJavacWarnings.txt=patch-work/filteredTrunkJavacWarnings.txt,
 patch-work/testrun_ambari-server.txt=patch-work/testrun_ambari-server.txt, 
patch-work/trunkCompile.txt=patch-work/trunkCompile.txt, 
patch-work/patchReleaseAuditWarnings.txt=patch-work/patchReleaseAuditWarnings.txt,
 patch-work/patchJavacWarnings.txt=patch-work/patchJavacWarnings.txt, 
patch-work/patchReleaseAuditOutput.txt=patch-work/patchReleaseAuditOutput.txt} 
due to internal error; falling back to full archiving
java.lang.IllegalStateException: checksum mismatch after transfer 
(6577874794637500461 vs. 744587978); 
/x1/jenkins/jenkins-home/jobs/Ambari-trunk-test-patch/builds/2014-12-17_17-03-16/archive/patch-work/testrun_ambari-server.txt
 may be corrupted
        at jsync.protocol.FileSequenceReader.read(FileSequenceReader.java:45)
        at 
com.cloudbees.jenkins.plugins.jsync.archiver.JSyncArtifactManager.remoteSync(JSyncArtifactManager.java:145)
        at 
com.cloudbees.jenkins.plugins.jsync.archiver.JSyncArtifactManager.archive(JSyncArtifactManager.java:68)
        at hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:140)
        at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
        at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
        at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
        at hudson.model.Build$BuildExecution.post2(Build.java:182)
        at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
        at hudson.model.Run.execute(Run.java:1731)
        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
        at hudson.model.ResourceController.execute(ResourceController.java:88)
        at hudson.model.Executor.run(Executor.java:232)
Finished: ABORTED
```

# Local Results
Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.569 sec

Tests run: 2433, Failures: 0, Errors: 0, Skipped: 13


Thanks,

Robert Levas

Reply via email to