-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29167/
-----------------------------------------------------------
(Updated Dec. 17, 2014, 7:24 p.m.)
Review request for Ambari, John Speidel, Nate Cole, Robert Nettleton, and Tom
Beerbower.
Changes
-------
Updates due to reviewer comments.
Updated unit tests to provide necessary data in ClusterRequest to avoid
AmbariException being thrown:
* org.apache.ambari.server.controller.AmbariManagementControllerImplTest
* org.apache.ambari.server.controller.AmbariManagementControllerTest
* org.apache.ambari.server.controller.internal.JMXHostProviderTest
Bugs: AMBARI-8756
https://issues.apache.org/jira/browse/AMBARI-8756
Repository: ambari
Description
-------
When setting the Cluster session attributes, they should be set before
performing the update operations since the attributes may be needed during the
process.
Soltions sets session attributes before updating the cluster by using the
`cluster ID` from the `request` to get relevant `cluster` rather than rely on
the `cluster name`; since the name could be changing per the request data.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
f58fa9d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
5208a2d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
eb14c20
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
7cb9aba
Diff: https://reviews.apache.org/r/29167/diff/
Testing (updated)
-------
# Local Results
Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.504 sec
Running org.apache.ambari.server.controller.AmbariManagementControllerTest
Tests run: 118, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 173.504 sec
Running org.apache.ambari.server.controller.internal.JMXHostProviderTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.427 sec
Complete Ambari-Server Test Suite
Tests run: 2437, Failures: 0, Errors: 0, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:15.205s
[INFO] Finished at: Wed Dec 17 19:14:46 EST 2014
[INFO] Final Memory: 47M/1080M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas