-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65939
-----------------------------------------------------------



ambari-metrics/ambari-metrics-assembly/pom.xml
<https://reviews.apache.org/r/29181/#comment109211>

    profile with id "windows" does not have closing tag


- Eugene Chekanskiy


On Dec. 19, 2014, 2:34 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 2:34 a.m.)
> 
> 
> Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8770
>     https://issues.apache.org/jira/browse/AMBARI-8770
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline 
> Service (Collector).
> 
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/windows/service_wrapper.py 
> 40be1d0ef125ab299042ccfe71d313c420515624 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 
> 3f4819d0b0306fd1bba09f0772c0a5cf458def60 
>   ambari-common/src/main/python/ambari_commons/os_windows.py 
> 2fb98e49478640ebfbabb820683c83331b7ed510 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 
> 0a0afbdd18532aad87eee6a67993e1a82f73dd98 
>   
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 
> 3513972d3b58f7e01016152f556c57b17fa18e6f 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-host-monitoring/pom.xml 
> 6080c8d16fecb0436ec539ed35527ff7a2d1ec87 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py
>  996120fd405bba2a43594343d618e23b3394d498 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  daabf37263fce558456cdc978822e41332478d91 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
>  51f0980b82042b5c1b86781f37418457de0066c2 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> be83250b9a0113b0794a8874f37440c7d53065ec 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 
> 09ae7e4750dc04266a5831626454077da3e71596 
>   
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 
> 5141359428c57291ee4e46a00b563f0c23d050a2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py 
> PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29181/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> Smoke test on the local machine
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Reply via email to