-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 10:35 a.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav
Papirkovskyy, and Sid Wagle.
Changes
-------
+ Fixed unit tests
+ Added support for unit testing on MacOS and Windows
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline
Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-metrics/ambari-metrics-assembly/pom.xml
1e020cbf220ee614bd82e67a5b7538b277bdf806
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml
PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml
PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml
3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml
c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py
996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py
51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py
PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py
09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py
05362bfd55151ec0759b746924af3547c76bd703
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml
196d7a12154f1903bd588c425eacf70c3525816d
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py
PRE-CREATION
ambari-metrics/pom.xml da7fc14064889f09f102dcbcaabaca880ac4f8e7
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
