> On Дек. 23, 2014, 10:19 п.п., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java, > > line 28 > > <https://reviews.apache.org/r/29378/diff/1/?file=799695#file799695line28> > > > > Why is repositoryVersionName not a requirement in the constructor?
For backward compatibility. Right now the checks should work even without changes on UI side, the check for repository version will be just skipped. I'll add TODO mark here to fix it in the future. - Yurii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29378/#review65972 ----------------------------------------------------------- On Дек. 23, 2014, 8:41 п.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29378/ > ----------------------------------------------------------- > > (Updated Дек. 23, 2014, 8:41 п.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8898 > https://issues.apache.org/jira/browse/AMBARI-8898 > > > Repository: ambari > > > Description > ------- > > The following checks should be implemented: > *All* cluster hosts must satisfy the following: > 1) It is either in Host Maintenance Mode or heartbeating with the server > 2) If in Host Maintenance Mode, there are no masters on the host > 3) If not in Host Maintenance Mode, it must have new version installed > *All* of the following must be satisfied: > 1) NameNode HA is enabled > 2) Make sure work-preserving RM/NM restart is enabled in YARN configuration > files > 3) MR Jobs need to reference the Hadoop libraries from the distributed cache > instead of the cluster > 4) Tez jobs need to reference the Hadoop libraries from the distributed cache > instead of the cluster > 5) Oozie jobs need to reference the Hadoop libraries from the distributed > cache instead of the cluster > 6) All services must be up, not in Service Maintenance Mode, and operational > (all components are up and service check should pass*). > 7) All DataNode decommissioning must be completed (no DataNode in > “decommissioning” state) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > 0cb20c1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > 1afc850 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeChecks.java > 83cd632 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeCheck.java > 0d85a93 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeCheckHelperTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29378/diff/ > > > Testing > ------- > > Tests are passing > > > Thanks, > > Yurii Shylov > >
