> On Dec. 23, 2014, 5:03 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java,
> > line 57
> > <https://reviews.apache.org/r/29378/diff/1/?file=799696#file799696line57>
> >
> > Maybe just "repository_version" for consistency with other endpoints.
>
> Yurii Shylov wrote:
> Are you sure about this one? Originally I've also made it just
> repository_version, but it might be confusing. For example, people will just
> put only version, i.e. 2.2.1.0
Yes, we should be using the same names that are used when invoking an upgrade.
So for example, to start an upgrade, this body is sent to the
/api/v1/clusters/c1/upgrades endpoint:
{
"Upgrade": {
"repository_version": "2.2.1.0-2148"
}
}
The names should match.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29378/#review65973
-----------------------------------------------------------
On Dec. 23, 2014, 3:41 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29378/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 3:41 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate
> Cole.
>
>
> Bugs: AMBARI-8898
> https://issues.apache.org/jira/browse/AMBARI-8898
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The following checks should be implemented:
> *All* cluster hosts must satisfy the following:
> 1) It is either in Host Maintenance Mode or heartbeating with the server
> 2) If in Host Maintenance Mode, there are no masters on the host
> 3) If not in Host Maintenance Mode, it must have new version installed
> *All* of the following must be satisfied:
> 1) NameNode HA is enabled
> 2) Make sure work-preserving RM/NM restart is enabled in YARN configuration
> files
> 3) MR Jobs need to reference the Hadoop libraries from the distributed cache
> instead of the cluster
> 4) Tez jobs need to reference the Hadoop libraries from the distributed cache
> instead of the cluster
> 5) Oozie jobs need to reference the Hadoop libraries from the distributed
> cache instead of the cluster
> 6) All services must be up, not in Service Maintenance Mode, and operational
> (all components are up and service check should pass*).
> 7) All DataNode decommissioning must be completed (no DataNode in
> “decommissioning” state)
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
> 0cb20c1
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
> 1afc850
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeChecks.java
> 83cd632
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeCheck.java
> 0d85a93
>
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeCheckHelperTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29378/diff/
>
>
> Testing
> -------
>
> Tests are passing
>
>
> Thanks,
>
> Yurii Shylov
>
>
