> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/ranger-hbase-plugin.xml,
> > lines 1-11
> > <https://reviews.apache.org/r/29474/diff/1/?file=803183#file803183line1>
> >
> > I will suggest that instead of introducing a new file
> > "ranger-${serviceName}-plugin" files in supported services, we can have
> > just one file in ranger service definition "ranger-plugin.xml" file.
> >
> > By doing this all plugin enabled flags will be contained in one file
> > and will appear on UI only if ranger is selected to be installed.
>
> Gautam Borad wrote:
> My understanding is that we are going to add a toggle checkbox to
> enable/disable ranger from UI. This xml was added to use whatever we can from
> stack definition and present to user the option to enable/disable.
Removed file ranger-${serviceName}-plugin from all services. Added this
property in ranger-${serviceName}-plugin-properties.xml for all services
> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py,
> > line 11
> > <https://reviews.apache.org/r/29474/diff/1/?file=803188#file803188line11>
> >
> > Please specify the timeout over here and at similar places in the other
> > services
Implemented this change in latest patch file
> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml,
> > lines 20-24
> > <https://reviews.apache.org/r/29474/diff/1/?file=803212#file803212line20>
> >
> > More suitable default value for the property will be
> > ldap://localhost:389
Implemented this change in latest patch file
> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> > lines 11-12
> > <https://reviews.apache.org/r/29474/diff/1/?file=803214#file803214line11>
> >
> > Remove the print statements
Implemented this change in latest patch file
> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py,
> > lines 59-68
> > <https://reviews.apache.org/r/29474/diff/1/?file=803217#file803217line59>
> >
> > Either include the log statements or remove commmented lines and
> > refactor the code
Implemented this change in latest patch file
> On Jan. 2, 2015, 8:26 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> > line 9
> > <https://reviews.apache.org/r/29474/diff/1/?file=803215#file803215line9>
> >
> > Please remove the print statemets over here and below
Implemented this change in latest patch file
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29474/#review66548
-----------------------------------------------------------
On Jan. 6, 2015, 5:09 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29474/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 5:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin
> Jetly, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-8949
> https://issues.apache.org/jira/browse/AMBARI-8949
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Ranger support to Ambari for Installation/Management/Monitoring.
>
> Supports of the following Ranger components:
> 1] Ranger Admin
> 2] Ranger User Sync
> 3] Ranger Plugins ( currently HDFS, Hive, HBase, Knox, Storm)
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/ranger-hbase-plugin-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/ranger-hbase-plugin.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
> 18572ef
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
> c0e84b4
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py
> 23c2f6c
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/ranger_admin.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/ranger-hdfs-plugin-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/ranger-hdfs-plugin.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
> ce0ab29
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
> e8dfe16
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
> 3a9d074
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/ranger_admin.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/ranger-hive-plugin-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/ranger-hive-plugin.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml
> db48936
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
> 735d59d
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py
> 8e6eacb
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/ranger_admin.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml
> ce4448f
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
> f578926
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py
> a2b122a
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/ranger_admin.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml
> PRE-CREATION
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
> PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json
> e8bbe32
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29474/diff/
>
>
> Testing
> -------
>
> Performed the following steps to integrate Ranger :
>
> Ranger Admin & Ranger User Sync
> -------------------------------
> 1] Add Ranger related files under
> /var/lib/ambari-server/resources/common-services/RANGER/0.4.0/
> 2] Add the right path in file
> /var/lib/ambari-server/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml
> 3] Add the same path in file
> /var/lib/ambari-agent/cache/stacks/HDP/2.2/services/RANGER/metainfo.xml
> 4] Restart Ambari Server
> 5] Ranger service was available on Ambari UI.
>
>
> Ranger Plugins
> --------------
> Same set of steps did not work for Ranger Plugins. To resolve the same, we
> had to add the changes in stacks of each component to ambari-server and
> ambari-agents cache folders [This part is not included in this attached
> patch].
>
>
> Thanks,
>
> Gautam Borad
>
>