> On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py, > > line 28 > > <https://reviews.apache.org/r/29474/diff/1/?file=803185#file803185line28> > > > > We should use named imports whenever possible instead of *
Implemented this change in latest patch file > On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py, > > line 174 > > <https://reviews.apache.org/r/29474/diff/1/?file=803186#file803186line174> > > > > Should perhaps initialize this to False despite the userInput value. Implemented this change in latest patch file > On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/ranger_admin.py, > > line 24 > > <https://reviews.apache.org/r/29474/diff/1/?file=803187#file803187line24> > > > > For function names, we typically follow the PEP 8 guide, e.g., > > get_repository_by_name_pycurl Implemented this change in latest patch file > On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/ranger_admin.py, > > line 27 > > <https://reviews.apache.org/r/29474/diff/1/?file=803187#file803187line27> > > > > Should the username and password be hardcoded? Implemented this change in latest patch file > On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/ranger_admin.py, > > line 50 > > <https://reviews.apache.org/r/29474/diff/1/?file=803187#file803187line50> > > > > Ideally, should get the return code instead of searching for text in > > the response. Implemented this change in latest patch file > On Dec. 30, 2014, 6:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py, > > line 25 > > <https://reviews.apache.org/r/29474/diff/1/?file=803192#file803192line25> > > > > Prefer named imports over * Implemented this change in latest patch file - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29474/#review66386 ----------------------------------------------------------- On Jan. 6, 2015, 5:09 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29474/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 5:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Velmurugan Periasamy, and Yusaku Sako. > > > Bugs: AMBARI-8949 > https://issues.apache.org/jira/browse/AMBARI-8949 > > > Repository: ambari > > > Description > ------- > > Add Ranger support to Ambari for Installation/Management/Monitoring. > > Supports of the following Ranger components: > 1] Ranger Admin > 2] Ranger User Sync > 3] Ranger Plugins ( currently HDFS, Hive, HBase, Knox, Storm) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/ranger-hbase-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/ranger-hbase-plugin.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml > 18572ef > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py > c0e84b4 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > 23c2f6c > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/ranger_admin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/ranger-hdfs-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/ranger-hdfs-plugin.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > ce0ab29 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > e8dfe16 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py > 3a9d074 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/ranger_admin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/ranger-hive-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/ranger-hive-plugin.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml > db48936 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > 735d59d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py > 8e6eacb > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/ranger_admin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml > ce4448f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > f578926 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py > a2b122a > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/ranger_admin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json > e8bbe32 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/29474/diff/ > > > Testing > ------- > > Performed the following steps to integrate Ranger : > > Ranger Admin & Ranger User Sync > ------------------------------- > 1] Add Ranger related files under > /var/lib/ambari-server/resources/common-services/RANGER/0.4.0/ > 2] Add the right path in file > /var/lib/ambari-server/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml > 3] Add the same path in file > /var/lib/ambari-agent/cache/stacks/HDP/2.2/services/RANGER/metainfo.xml > 4] Restart Ambari Server > 5] Ranger service was available on Ambari UI. > > > Ranger Plugins > -------------- > Same set of steps did not work for Ranger Plugins. To resolve the same, we > had to add the changes in stacks of each component to ambari-server and > ambari-agents cache folders [This part is not included in this attached > patch]. > > > Thanks, > > Gautam Borad > >
