> On Jan. 14, 2015, 5:03 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 698 > > <https://reviews.apache.org/r/29897/diff/1/?file=821655#file821655line698> > > > > Oracle should use NUMBER(19)
Huh - must have been a merge thing. Will correct. > On Jan. 14, 2015, 5:03 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 462 > > <https://reviews.apache.org/r/29897/diff/1/?file=821647#file821647line462> > > > > What is the fromVersion used for? When we initiate an upgrade, we don't save the from/to versions. So when an upgrade fails, we need to know what the version the downgrade should be applied. So I'm saving that information such that when you downgrade, you supply the value of from_version. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29897/#review68128 ----------------------------------------------------------- On Jan. 14, 2015, 4:27 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29897/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 4:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-9135 > https://issues.apache.org/jira/browse/AMBARI-9135 > > > Repository: ambari > > > Description > ------- > > Added version checking for downgrades only. Upgrades should always use all > services and components > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 0a11aca > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 2c19da3 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 724bcdc > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java > 8ea259d > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 04e8eb3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > ef605ec > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > dae920e > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4e61f36 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 59031f7 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7b64212 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > bfb49e5 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e6f2edb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 2888eca > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 73531ec > > Diff: https://reviews.apache.org/r/29897/diff/ > > > Testing > ------- > > Pending > > > Thanks, > > Nate Cole > >
