> On Jan. 14, 2015, 11:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java, > > line 144 > > <https://reviews.apache.org/r/29897/diff/2/?file=821983#file821983line144> > > > > Documentation
Will do. > On Jan. 14, 2015, 11:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, > > line 480 > > <https://reviews.apache.org/r/29897/diff/2/?file=821985#file821985line480> > > > > Documentation Will do. > On Jan. 14, 2015, 11:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java, > > line 66 > > <https://reviews.apache.org/r/29897/diff/2/?file=821983#file821983line66> > > > > Document how specifying a version changes the behavior of the MHR? Will do. > On Jan. 14, 2015, 11:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java, > > line 157 > > <https://reviews.apache.org/r/29897/diff/2/?file=821983#file821983line157> > > > > I don't think you need the null check here; > > `!m_version.equals(sch.getVersion())` should be enough since `m_version` > > cannot be null. The null check is on **sch**.getVersion(), which I have as seen null (but better not be). You are correct that m_version cannot be null at this point in code. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29897/#review68202 ----------------------------------------------------------- On Jan. 14, 2015, 6:58 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29897/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 6:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-9135 > https://issues.apache.org/jira/browse/AMBARI-9135 > > > Repository: ambari > > > Description > ------- > > Added version checking for downgrades only. Upgrades should always use all > services and components > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 0a11aca > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 2c19da3 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 724bcdc > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java > 8ea259d > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 04e8eb3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > ef605ec > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > dae920e > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4e61f36 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 59031f7 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7b64212 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > bfb49e5 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e6f2edb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 2888eca > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java > 113de2d > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 73531ec > > Diff: https://reviews.apache.org/r/29897/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:06.457s > [INFO] Finished at: Wed Jan 14 18:56:49 EST 2015 > [INFO] Final Memory: 31M/345M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
