----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29951/#review68348 -----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js <https://reviews.apache.org/r/29951/#comment112527> This is not correct. The pattern should be x.y[-z] where -z is optional, and x, y, z are non-negative integers. There should not be any min 4 digit requirement on the optional build number and .y part should not be optional. - Yusaku Sako On Jan. 15, 2015, 11:01 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29951/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 11:01 p.m.) > > > Review request for Ambari, Andrii Tkach and Yusaku Sako. > > > Bugs: AMBARI-9164 > https://issues.apache.org/jira/browse/AMBARI-9164 > > > Repository: ambari > > > Description > ------- > > Adjust regex. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > bdfb755 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js > abae72a > > Diff: https://reviews.apache.org/r/29951/diff/ > > > Testing > ------- > > All unit test passed. New unit test provided. > > > Thanks, > > Richard Zang > >
