----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29951/#review68347 -----------------------------------------------------------
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js <https://reviews.apache.org/r/29951/#comment112526> I believe this should be ^(\d+.)*\d+(-\d+)?$ Try this pattern on regexpal.com ^(\d+.)*\d+(-\d+)? (pass)?(fail)?$ With this text: 1 pass 1. fail 1- fail 1-1 pass 1.-1 fail 1.2 pass 1.2-1 pass 1.2- fail 1.2.3 pass 1.2.3- fail 1.2.3. fail 1.2.3-1 pass 1.2.3-1234 pass 1.2.3-12. fail 1.2.3.1234 pass - Alejandro Fernandez On Jan. 15, 2015, 11:01 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29951/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 11:01 p.m.) > > > Review request for Ambari, Andrii Tkach and Yusaku Sako. > > > Bugs: AMBARI-9164 > https://issues.apache.org/jira/browse/AMBARI-9164 > > > Repository: ambari > > > Description > ------- > > Adjust regex. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > bdfb755 > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js > abae72a > > Diff: https://reviews.apache.org/r/29951/diff/ > > > Testing > ------- > > All unit test passed. New unit test provided. > > > Thanks, > > Richard Zang > >
