> On Jan. 20, 2015, 4:06 p.m., Jonathan Hurley wrote: > >
Thanks for reviewing! > On Jan. 20, 2015, 4:06 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java, > > line 57 > > <https://reviews.apache.org/r/30077/diff/1/?file=826857#file826857line57> > > > > Should this be protected in order to let subresources modify it? Sub resources can still access the collection through getCreateDirectives() and can still add/remove directives to that collection. I think that this is basically the same as the existing code, just that now the base level collection of create directives can be populated through a constructor. > On Jan. 20, 2015, 4:06 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClientConfigResourceDefinition.java, > > lines 61-67 > > <https://reviews.apache.org/r/30077/diff/1/?file=826858#file826858line61> > > > > You removed `validate_topology` but it never gets added to > > `createDirectives`; how does this directive get used now? This actually had nothing to do with the Jira. I just noticed this bad cut and paste job so I cleaned it up. Client configs doesn't use the directive. It just carried over from when the Blueprint resource definition was copied to create the client config definition. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30077/#review68727 ----------------------------------------------------------- On Jan. 20, 2015, 3:41 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30077/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 3:41 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-9214 > https://issues.apache.org/jira/browse/AMBARI-9214 > > > Repository: ambari > > > Description > ------- > > Add an Upgrade ResourceDefinition so that we can use these directives: > > downgrade: boolean that makes the upgrade a downgrade > skip_service_checks: boolean that disables the upcoming service-check-all > after core components > > > Also cleaned up a sloppy cut and paste job in ClientConfigResourceDefinition. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java > 1cd7e17 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClientConfigResourceDefinition.java > 4ff37ac > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > fc28c13 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java > 92ecd1e > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d9c9aec > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java > 73aa828 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java > d264511 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > cd5f23e > > Diff: https://reviews.apache.org/r/30077/diff/ > > > Testing > ------- > > Unit tests added. All existing tests pass. > > Manual tests in progress... > > > Thanks, > > Tom Beerbower > >
