> On Jan. 20, 2015, 4:45 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 529-531 > > <https://reviews.apache.org/r/30077/diff/1/?file=826862#file826862line529> > > > > I'm not sure this is what should be happening. I think the directive > > may be to prevent the "full service check" from happening (3 times this > > gets scheduled). This code will stop all service checks from happening. > > Let's confirm with Yusaku since he was requesting it.
Ok, I assumed that the "full" service check was just the collection of all the individual service checks. Where does the "full service check" stage get created? Is there already logic in place to skip it and I just need to hook up the directive? Thanks for the review! - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30077/#review68730 ----------------------------------------------------------- On Jan. 20, 2015, 3:41 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30077/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 3:41 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-9214 > https://issues.apache.org/jira/browse/AMBARI-9214 > > > Repository: ambari > > > Description > ------- > > Add an Upgrade ResourceDefinition so that we can use these directives: > > downgrade: boolean that makes the upgrade a downgrade > skip_service_checks: boolean that disables the upcoming service-check-all > after core components > > > Also cleaned up a sloppy cut and paste job in ClientConfigResourceDefinition. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java > 1cd7e17 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClientConfigResourceDefinition.java > 4ff37ac > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > fc28c13 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java > 92ecd1e > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d9c9aec > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java > 73aa828 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java > d264511 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > cd5f23e > > Diff: https://reviews.apache.org/r/30077/diff/ > > > Testing > ------- > > Unit tests added. All existing tests pass. > > Manual tests in progress... > > > Thanks, > > Tom Beerbower > >
