> On Jan. 21, 2015, 12:57 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java, > > lines 291-293 > > <https://reviews.apache.org/r/30101/diff/2/?file=827778#file827778line291> > > > > Typically booleans are prefixed with "is": isAdvertiseVersion()
Will fix. > On Jan. 21, 2015, 12:57 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > lines 241-243 > > <https://reviews.apache.org/r/30101/diff/2/?file=827783#file827783line241> > > > > Typically booleans are prefixed with "is": isAdvertiseVersion() Will fix. > On Jan. 21, 2015, 12:57 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java, > > line 61 > > <https://reviews.apache.org/r/30101/diff/2/?file=827786#file827786line61> > > > > Does this really need to be in the ServiceComponentImpl? It's not like > > we change the runtime value from the stack-defined value (I would hope) I only used it in ComponentInfo, but I can get John's input on this. > On Jan. 21, 2015, 12:57 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java, > > line 1721 > > <https://reviews.apache.org/r/30101/diff/2/?file=827788#file827788line1721> > > > > @Transactional here WITH the locks seems a bit excessive. The DAO are > > already littered with that annotation and the r/w locks aren't cheap. I added it as a pre-caution, but I can remove the locking code since we get sequential heartbeats per component on a host that advertises the version. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30101/#review68908 ----------------------------------------------------------- On Jan. 21, 2015, 6:45 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30101/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 6:45 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Tom Beerbower, and Yurii Shylov. > > > Bugs: AMBARI-9225 > https://issues.apache.org/jira/browse/AMBARI-9225 > > > Repository: ambari > > > Description > ------- > > Finalize requires all components to advertise a version, usually by calling > hdp-select. However, AMS (Metric Collector and Metric Monitor), Kerberos, and > ZKFC don't advertise a version. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 2c1f94f43ca16f8f73ba78d58f8d8e024eecf59e > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > 47d153b76e3a82eccbf0978543316728f89bb06d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 6d503e2b85c58d1a387e8057c6fabdc7d670d301 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java > 1f23773ad34932cb0e84e52950dce253f594853c > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java > feca2603c951e5f89717b33fbbc1d585cf7fc1ed > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java > f4e999946153901e4da16f1aac2e9516b5a5b508 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > dcfd00fb2b02ca00ee8980550040efc263854e06 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > 65c37f4793456871f63d852cdc18a414e58d3aee > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > e337153e993aabd441f616627dfb4724a761d479 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > a31e42c9e8a5d199a5ed2bfe82f0759104b49eb4 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > bf5bf503068aca6889e31a7ccdc3fdb8b616b23f > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 3593eb371cbf281d3a223a5d2747dd2b1cb64b5a > ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml > bcccb1d535bd2d08ad73f8bc6d7b40ca8c58fd51 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > ab7c95c45d78fd9110c69823f8bafe554754b50b > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml > db4893683b2e574e8ca4b9dce665c669ac7cad48 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > c78ce0b8c5285154b58c260a914ad264d2b37e83 > > Diff: https://reviews.apache.org/r/30101/diff/ > > > Testing > ------- > > Install Cluster Wizard Tests: > 1 host: correctly created HostVersion in UPGRADING state, then created a > ClusterVersion in UPGRADING. When the install finished, the HostVersion > transitioned to CURRENT, and so did the ClusterVersion right after. > 3 hosts with AMS: same as above, > 1 host, then installed additional AMS service: same as above. Because the > HostVersion and ClusterVersion was already in a CURRENT state, adding a > service did not change these entities. > 3 hosts with AMS< then installed YARN: same as above > > Rolling Upgrade Test: > 3-node cluster with HDFS, ZK, AMS, and ZKFC. > Right now it failed because all of the components are still in an INSTALLED > state and never transition to UPGRADING. > > > **Unit Tests are probably broken** > > > Thanks, > > Alejandro Fernandez > >
