----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30101/#review69095 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Jan. 21, 2015, 7:12 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30101/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 7:12 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Tom Beerbower, and Yurii Shylov. > > > Bugs: AMBARI-9225 > https://issues.apache.org/jira/browse/AMBARI-9225 > > > Repository: ambari > > > Description > ------- > > Finalize requires all components to advertise a version, usually by calling > hdp-select. However, AMS (Metric Collector and Metric Monitor), Kerberos, and > ZKFC don't advertise a version. > > Further, the transitions of the HostVersion and ClusterVersion need to go > through UPGRADING->UPGRADED->CURRENT for a brand new cluster. > And for a Rolling Upgrade, it needs to go through > INSTALLING->INSTALLED->UPGRADING->UPGRADED->CURRENT. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 2c1f94f43ca16f8f73ba78d58f8d8e024eecf59e > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > 47d153b76e3a82eccbf0978543316728f89bb06d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 6d503e2b85c58d1a387e8057c6fabdc7d670d301 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java > 1f23773ad34932cb0e84e52950dce253f594853c > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java > feca2603c951e5f89717b33fbbc1d585cf7fc1ed > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java > f4e999946153901e4da16f1aac2e9516b5a5b508 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > dcfd00fb2b02ca00ee8980550040efc263854e06 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > e337153e993aabd441f616627dfb4724a761d479 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > bf5bf503068aca6889e31a7ccdc3fdb8b616b23f > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 3593eb371cbf281d3a223a5d2747dd2b1cb64b5a > ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml > bcccb1d535bd2d08ad73f8bc6d7b40ca8c58fd51 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 3936043d289bda671773e89769ca1e616fb882e0 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml > da662cec7d4480e18843894a289f51482696234c > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > c78ce0b8c5285154b58c260a914ad264d2b37e83 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 7e53d76c59c5a226cb39da68fea3e06d9dbbb997 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > cf183ec803f7dbc3582cdc671b9bce4d7d466cee > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 535066212ce7510d804a54208ddd1bd433550983 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > be40a688bd1dba4c05567d74d5646cfe0031fc5c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > abd2c649420f54c94db6bf3d4fc6fc004441e859 > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > eabdc09fb232e73053a781a4ac1d1d7ebc584aee > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 9e1ada46a8eb5de03e9b56eae2b21b1f6e8c64ef > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 7ddf50f00faec4ad52a3b73f789f3eab793fd24e > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > e3d29d8474f6d02590347682d3b08e243b31b87d > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 04b4f81571b0df7b86d795ec8f74c187df6ccd8d > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > 30158cc156f65f0d472dabf985a5a8acab90e901 > > ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java > 2aac5f489a25d5f08957d0e1e88157ac4c621a85 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > bb0836fde0e08658a78f8c3b33a98289fa9a09f6 > > Diff: https://reviews.apache.org/r/30101/diff/ > > > Testing > ------- > > Install Cluster Wizard Tests: > 1 host: correctly created HostVersion in UPGRADING state, then created a > ClusterVersion in UPGRADING. When the install finished, the HostVersion > transitioned to CURRENT, and so did the ClusterVersion right after. > 3 hosts with AMS: same as above, > 1 host, then installed additional AMS service: same as above. Because the > HostVersion and ClusterVersion was already in a CURRENT state, adding a > service did not change these entities. > 3 hosts with AMS< then installed YARN: same as above > > Rolling Upgrade Test: > 3-node cluster with HDFS, ZK, AMS, and ZKFC. > > Correctly transitioned through the states. > > Unit Tests passed. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:11.101s > [INFO] Finished at: Wed Jan 21 15:44:12 PST 2015 > > > Thanks, > > Alejandro Fernandez > >
