----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30202/#review69328 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment113993> ConfigHelper is now needed by MasterHostResolver ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment113994> There's similar logic in the python scripts. ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment113995> Default is for HTTP protocol instead of HTTPS. ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java <https://reviews.apache.org/r/30202/#comment113997> Broke this out since I needed to call it from MasterHostResolver ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java <https://reviews.apache.org/r/30202/#comment113998> See unit test below. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py <https://reviews.apache.org/r/30202/#comment114002> This is where the magic happens. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py <https://reviews.apache.org/r/30202/#comment113999> @Jonathan, at some point we can refactor the alerts python files to use this class. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py <https://reviews.apache.org/r/30202/#comment114000> The __str__ comes in pretty handy. - Alejandro Fernandez On Jan. 23, 2015, 1:48 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30202/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 1:48 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > and Yurii Shylov. > > > Bugs: AMBARI-9289 > https://issues.apache.org/jira/browse/AMBARI-9289 > > > Repository: ambari > > > Description > ------- > > Java-side: > UpgradeHelper hardcodes the JMX port number when figuring out the active and > standby namenodes. > > Python-side: > When using HA mode, the JMX URLs for NameNode must be taken from > dfs.namenode.http-address.<cluster>.<nn#> > See journalnode_upgrade.py > E.g., > dfs.namenode.http-address.ha.nn1 : c6405.ambari.apache.org:50070 > dfs.namenode.http-address.ha.nn2 : c6403.ambari.apache.org:50070 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > f49e66675fbf1289cd7b797784f14bd8d631f1bf > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > ba5e804acea3a888036822aa2ec9789f536418d6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 746a04ace69a4d8b1c66215901d351f8a2395ef9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 239c79c7c1d5b4896a8ab1b90611caef0baced20 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 122e0a3b5e3de9084bd8282104c1642237ae5184 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > e3d8619df3a6f0f579b8e592f0ac6bdf51be610f > ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java > 38ac6435e0876c946101582856b5a4a6e19ef5dd > ambari-server/src/main/java/org/apache/ambari/server/utils/HostAndPort.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py > 4e85130d3538f0d76a093a7e0cbcdefec4f6088b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 2634ce8fe1255d1d8a3b8a11ae1b6d17b2dc779e > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestHTTPUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30202/diff/ > > > Testing > ------- > > Verified that both fixes worked in a 3-node HA cluster when performing a > Rolling Upgrade. > The first item is to allow the resolution of the active/standby namendoes to > occur, which is needed by Namenode Prepare and RESTART. > The second item is for the Journalnode restart to query JMX correctly. > > Waiting for unit-test results. > > > Thanks, > > Alejandro Fernandez > >
