----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30202/#review69388 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114081> configHelper param ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114082> configHelper param ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114087> This method is geared to only work for NN HA (2 or more name nodes). This line should be removed and the callers of this method should not call it unless there are 2 hosts. ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114083> As this doesn't change, it could just be a static. In fact, it seems as though this kind of configuration type (and the others) should all be public statics somewhere. ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114084> Inline return; change to {} for better visual structure. ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114085> Inline return; use {} ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java <https://reviews.apache.org/r/30202/#comment114086> "HTTPS_ONLY" should probably be a public static somewhere. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py <https://reviews.apache.org/r/30202/#comment114088> This uses url2lib instead of curl; Alerts just got slammed with this when the environment was kerberized. Without a proper keytab, the URL request would hit a 401 Unauthorized error. Do we use this pattern a lot? I'd think it would fail all over the place. - Jonathan Hurley On Jan. 22, 2015, 9:13 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30202/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 9:13 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > and Yurii Shylov. > > > Bugs: AMBARI-9289 > https://issues.apache.org/jira/browse/AMBARI-9289 > > > Repository: ambari > > > Description > ------- > > Java-side: > UpgradeHelper hardcodes the JMX port number when figuring out the active and > standby namenodes. > > Python-side: > When using HA mode, the JMX URLs for NameNode must be taken from > dfs.namenode.http-address.<cluster>.<nn#> > See journalnode_upgrade.py > E.g., > dfs.namenode.http-address.ha.nn1 : c6405.ambari.apache.org:50070 > dfs.namenode.http-address.ha.nn2 : c6403.ambari.apache.org:50070 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > f49e66675fbf1289cd7b797784f14bd8d631f1bf > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > ba5e804acea3a888036822aa2ec9789f536418d6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 746a04ace69a4d8b1c66215901d351f8a2395ef9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 239c79c7c1d5b4896a8ab1b90611caef0baced20 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 122e0a3b5e3de9084bd8282104c1642237ae5184 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > e3d8619df3a6f0f579b8e592f0ac6bdf51be610f > ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java > 38ac6435e0876c946101582856b5a4a6e19ef5dd > ambari-server/src/main/java/org/apache/ambari/server/utils/HostAndPort.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py > 4e85130d3538f0d76a093a7e0cbcdefec4f6088b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > 2634ce8fe1255d1d8a3b8a11ae1b6d17b2dc779e > > ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java > e6cc089a1c3a465e87eabc2f1bd7832d62f9b0a7 > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestHTTPUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30202/diff/ > > > Testing > ------- > > Verified that both fixes worked in a 3-node HA cluster when performing a > Rolling Upgrade. > The first item is to allow the resolution of the active/standby namendoes to > occur, which is needed by Namenode Prepare and RESTART. > The second item is for the Journalnode restart to query JMX correctly. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:14.455s > [INFO] Finished at: Thu Jan 22 18:11:41 PST 2015 > [INFO] Final Memory: 50M/758M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > >
