-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30202/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 10:36 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and 
Yurii Shylov.


Changes
-------

Tested on a Kerberized cluster, and fixed hacks for HBase and RM.


Bugs: AMBARI-9289
    https://issues.apache.org/jira/browse/AMBARI-9289


Repository: ambari


Description
-------

Java-side:
UpgradeHelper hardcodes the JMX port number when figuring out the active and 
standby namenodes.

Python-side:
When using HA mode, the JMX URLs for NameNode must be taken from 
dfs.namenode.http-address.<cluster>.<nn#>
See journalnode_upgrade.py
E.g.,
dfs.namenode.http-address.ha.nn1 : c6405.ambari.apache.org:50070
dfs.namenode.http-address.ha.nn2 : c6403.ambari.apache.org:50070


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 f49e666 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 ba5e804 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 28538c0 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
 239c79c 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
122e0a3 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java 
38ac643 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HostAndPort.java 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py
 2881c3f 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 7f0971d 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py
 bc37240 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
 472d684 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 2634ce8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java 
e6cc089 
  ambari-server/src/test/java/org/apache/ambari/server/utils/TestHTTPUtils.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/30202/diff/


Testing
-------

Verified that both fixes worked in a 3-node HA cluster when performing a 
Rolling Upgrade.
The first item is to allow the resolution of the active/standby namendoes to 
occur, which is needed by Namenode Prepare and RESTART.
The second item is for the Journalnode restart to query JMX correctly.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:14.455s
[INFO] Finished at: Thu Jan 22 18:11:41 PST 2015
[INFO] Final Memory: 50M/758M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez

Reply via email to