> On Feb. 14, 2015, 1:32 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java,
> >  lines 1441-1457
> > <https://reviews.apache.org/r/31035/diff/1/?file=864036#file864036line1441>
> >
> >     It seems like `KerberosHelper.validateKDCCredentials` should throw 
> > (more) specific Kerberos*Exceptions rather then the general 
> > IllegalArguementAcception.   It may take a bit more work to do this, but 
> > removes the *guess work* out of determing what is acutally going on. I 
> > think of the IllegalArguement exceptions as a interface to an *external* 
> > caller not an *internal* caller.

Agreed, it bothered me also so I am going to fix it.  See my response to 
Rishi's similar comment above.


> On Feb. 14, 2015, 1:32 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java,
> >  line 1437
> > <https://reviews.apache.org/r/31035/diff/1/?file=864036#file864036line1437>
> >
> >     Bummer more server-specific logic bleeding in..

yeah, given some time I could have made a generic mechanism where we could 
register specific handlers based on indentity but it doesn't make sense to do 
now.


> On Feb. 14, 2015, 1:32 a.m., Robert Levas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java,
> >  line 263
> > <https://reviews.apache.org/r/31035/diff/1/?file=864037#file864037line263>
> >
> >     Your test case needs to mock up krb5-conf and kerberos-env 
> > configurations.  See 
> > `org.apache.ambari.server.controller.KerberosHelperTest#testEnableKerberos(org.apache.ambari.server.serveraction.kerberos.KerberosCredential,
> >  boolean, boolean)` for an example.

Thanks Rob I have fixed this and will update a new patch shortly.  One note, in 
the original test there was a lot of usages on ".once()".  Using this when it 
isn't a requirement makes for more fragile tests.  For example if you have some 
state obect with a getName() method, expectations for this method should use 
".anyTimes()" and not ".once" because we don't care how many times it is 
called, it is merely an implementation detail.  ".once()" is should only really 
be used for cases where calling the method more than once would be incorrect or 
in some cases very expensive.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31035/#review72471
-----------------------------------------------------------


On Feb. 14, 2015, 1 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31035/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 1 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Tom Beerbower, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9640
>     https://issues.apache.org/jira/browse/AMBARI-9640
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add the following properties to the Kerberos service resource which provide 
> the results of the validation of the KDC admin credentials stored in session: 
> "Services/attributes/kdc_validation_result" and 
> "Services/attributes/kdc_validation_failure_details".
> 
> See the associated Jira for more details including full api responses.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  2e68c7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  40921f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
>  210c6a4 
> 
> Diff: https://reviews.apache.org/r/31035/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional Testing:
> - Tested all possible results of the validation
> - Tested when no kerberos service existed
> 
> Unit Tests:
> - Added new unit tests
> - Running entire unit test suite now and will post results prior to merging
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Reply via email to