-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31035/
-----------------------------------------------------------
(Updated Feb. 14, 2015, 9:30 p.m.)
Review request for Ambari, Robert Levas, Tom Beerbower, and Yusaku Sako.
Changes
-------
Addresses issues raised in review.
Bugs: AMBARI-9640
https://issues.apache.org/jira/browse/AMBARI-9640
Repository: ambari
Description
-------
Add the following properties to the Kerberos service resource which provide the
results of the validation of the KDC admin credentials stored in session:
"Services/attributes/kdc_validation_result" and
"Services/attributes/kdc_validation_failure_details".
See the associated Jira for more details including full api responses.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
2e68c7d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
40921f5
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosInvalidConfigurationException.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosMissingAdminCredentialsException.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
136615e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
210c6a4
Diff: https://reviews.apache.org/r/31035/diff/
Testing
-------
Manual Functional Testing:
- Tested all possible results of the validation
- Tested when no kerberos service existed
Unit Tests:
- Added new unit tests
- Running entire unit test suite now and will post results prior to merging
Thanks,
John Speidel